linux-kernel - Re: [PATCH 00/11] x86/microcode: Early load microcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50328722.9060009@zytor.com>
Date:	Mon, 20 Aug 2012 11:51:14 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Borislav Petkov <bp@...64.org>
CC:	Fenghua Yu <fenghua.yu@...el.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Asit K Mallick <asit.k.mallick@...el.com>,
	Tigran Aivazian <tigran@...azian.fsnet.co.uk>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Borislav Petkov <borislav.petkov@....com>,
	linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH 00/11] x86/microcode: Early load microcode

On 08/20/2012 08:39 AM, Borislav Petkov wrote:
> On Sat, Aug 18, 2012 at 01:15:18AM -0700, Fenghua Yu wrote:
>>  Documentation/x86/earlyucode.txt        |   43 +++
>>  arch/x86/Kconfig                        |   22 ++
>>  arch/x86/include/asm/cpio.h             |   10 +
>>  arch/x86/include/asm/microcode.h        |   23 ++
>>  arch/x86/include/asm/microcode_intel.h  |  103 +++++++
>>  arch/x86/kernel/Makefile                |    3 +
>>  arch/x86/kernel/head64.c                |    6 +
>>  arch/x86/kernel/head_32.S               |    6 +
>>  arch/x86/kernel/microcode_core.c        |    7 +-
>>  arch/x86/kernel/microcode_core_early.c  |   74 +++++
>>  arch/x86/kernel/microcode_intel.c       |  185 +------------
>>  arch/x86/kernel/microcode_intel_early.c |  482 +++++++++++++++++++++++++++++++
>>  arch/x86/kernel/microcode_intel_lib.c   |  163 +++++++++++
> 
> One more thing:
> 
> This screams for adding a directory called "microcode" in the kernel
> sources and moving all the microcode-related files there. IOW:
> 
> arch/x86/kernel/cpu/microcode/core.c
> arch/x86/kernel/cpu/microcode/core_early.c
> arch/x86/kernel/cpu/microcode/intel.c
> arch/x86/kernel/cpu/microcode/amd.c
> ...
> 
> And yes, they should be under "cpu" too.
> 

Not really, but that isn't even Fenghua's fault.

The cpu directory was originally for cpu detection.  The whole kernel/
directory, of course, is a morass that might as well be called "misc".
Some things are legitimately there -- mainly the syscall table and
things that mirror the global kernel/ -- but a ton of stuff doesn't make
any sense there.

Reorganizing the kernel/ directory and promoting cpu up one level would
make that make more sense.  The pci and irq code are examples of things
that could use their own directories.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/