lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Aug 2012 21:00:35 +0400 From: Max Filippov <jcmvbkbc@...il.com> To: Marina Makienko <makienko@...ras.ru> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, David Daney <david.daney@...ium.com>, Ralf Baechle <ralf@...ux-mips.org>, "Roy.Li" <rongqing.li@...driver.com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, ldv-project@...ras.ru Subject: Re: [PATCH] staging: octeon: Add prevent NAPI from scheduling On Mon, Aug 20, 2012 at 2:41 PM, Marina Makienko <makienko@...ras.ru> wrote: > Code inspection shows that this can > only be triggered by calling napi_enable() without > napi_disable(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Marina Makienko <makienko@...ras.ru> > --- > drivers/staging/octeon/ethernet-rx.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c > index 34afc16..db81613 100644 > --- a/drivers/staging/octeon/ethernet-rx.c > +++ b/drivers/staging/octeon/ethernet-rx.c > @@ -560,4 +560,5 @@ void cvm_oct_rx_shutdown(void) > /* Shutdown all of the NAPIs */ > for_each_possible_cpu(i) > netif_napi_del(&cvm_oct_napi[i].napi); > + napi_disable(&cvm_oct_napi[i].napi); > } Looks like napi_disable is meant to be inside for_each_possible_cpu loop, but curly braces are missing. -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists