linux-kernel - [PATCH] staging: octeon: Add prevent NAPI from scheduling IN-REPLY-TO:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1345535293-12800-1-git-send-email-makienko@ispras.ru>
Date:	Tue, 21 Aug 2012 11:48:13 +0400
From:	Marina Makienko <makienko@...ras.ru>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Marina Makienko <makienko@...ras.ru>,
	David Daney <david.daney@...ium.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	"Roy.Li" <rongqing.li@...driver.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, ldv-project@...ras.ru
Subject: [PATCH] staging: octeon: Add prevent NAPI from scheduling IN-REPLY-TO:

There are netif_napi_add() and napi_enable() in for_each_possible_cpu
loop in function cvm_oct_rx_initialize(). So it's logical to add
napi_disable() in for_each_possible_cpu loop in function
cvm_oct_rx_shutdown().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Marina Makienko <makienko@...ras.ru>
---
 drivers/staging/octeon/ethernet-rx.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
index 34afc16..e5b62fc 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -558,6 +558,8 @@ void cvm_oct_rx_shutdown(void)
 {
 	int i;
 	/* Shutdown all of the NAPIs */
-	for_each_possible_cpu(i)
+	for_each_possible_cpu(i) {
 		netif_napi_del(&cvm_oct_napi[i].napi);
+		napi_disable(&cvm_oct_napi[i].napi);
+	}
 }
-- 
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/