linux-kernel - Re: [PATCH] ARM: dt: tegra: harmony: add regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50327897.5030601@wwwdotorg.org>
Date:	Mon, 20 Aug 2012 11:49:11 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Laxman Dewangan <ldewangan@...dia.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Stephen Warren <swarren@...dia.com>,
	"olof@...om.net" <olof@...om.net>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] ARM: dt: tegra: harmony: add regulators

On 08/20/2012 11:22 AM, Laxman Dewangan wrote:
> On Saturday 18 August 2012 01:25 AM, Stephen Warren wrote:
>> On 08/17/2012 01:27 PM, Stephen Warren wrote:
>>> On 08/17/2012 12:59 AM, Laxman Dewangan wrote:
>>>> Harmony uses a TPS6586x regulator. Instantiate this, and hook up a
>>>> couple of fixed GPIO-controlled regulators too.
>>>>
>>>> Based on Ventana regulator patch by Stephen Warren<swarren@...dia.com>
>>>> and converted to Harmony.
>>> Thanks, applied to Tegra's for-3.7/dt branch.
>> Oh hang on, this adds regulators to DT, but doesn't do anything to
>> remove the board-file registration of Harmony's regulators from
>> board-dt-tegra20.c, which end up conflicting, and preventing the PCIe
>> driver from being registered.
>>
>> So, this patch really wants to remove the legacy code to, but doing so
>> will be problematic; to avoid runtime git bisect failures, we'd need to
>> merge the regulator tree in first, or wait until next kernel release or
>> something... Thoughts?
> 
> Why not just remove the regulator registration from board files along
> with the dt entry (in one patch). That will resolve the issue of bisect.

The problem there is that will prevent any regulators from being
registered at all, until the patch is merged with the regulator tree.
That will also prevent PCIe working on Harmony. Those both work right
now, so that's a bisection breakage.

I suppose the solution here is to merge the regulator tree into the
Tegra branch before the Harmony regulator patch. Mark, can we do that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/