| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Aug 2012 22:09:23 +0400 From: Vasiliy Kulikov <segoon@...nwall.com> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, containers@...ts.linux-foundation.org, David Miller <davem@...emloft.net>, Serge Hallyn <serge@...lyn.com> Subject: Re: [PATCH 07/21] userns: Use kgids for sysctl_ping_group_range On Mon, Aug 13, 2012 at 13:18 -0700, Eric W. Biederman wrote: > From: "Eric W. Biederman" <ebiederm@...ssion.com> > > - Store sysctl_ping_group_range as a paire of kgid_t values > instead of a pair of gid_t values. > - Move the kgid conversion work from ping_init_sock into ipv4_ping_group_range > - For invalid cases reset to the default disabled state. > > With the kgid_t conversion made part of the original value sanitation > from userspace understand how the code will react becomes clearer > and it becomes possible to set the sysctl ping group range from > something other than the initial user namespace. > > Cc: Vasiliy Kulikov <segoon@...nwall.com> > Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com> Looks good. Acked-by: Vasiliy Kulikov <segoon@...nwall.com> Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists