linux-kernel - Re: [PATCH] ARM: dt: tegra: harmony: add regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50327D2D.6000509@wwwdotorg.org>
Date:	Mon, 20 Aug 2012 12:08:45 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Laxman Dewangan <ldewangan@...dia.com>,
	Stephen Warren <swarren@...dia.com>,
	"olof@...om.net" <olof@...om.net>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] ARM: dt: tegra: harmony: add regulators

On 08/20/2012 11:54 AM, Mark Brown wrote:
> On Mon, Aug 20, 2012 at 11:49:11AM -0600, Stephen Warren wrote:
> 
>> The problem there is that will prevent any regulators from being 
>> registered at all, until the patch is merged with the regulator
>> tree. That will also prevent PCIe working on Harmony. Those both
>> work right now, so that's a bisection breakage.
> 
>> I suppose the solution here is to merge the regulator tree into
>> the Tegra branch before the Harmony regulator patch. Mark, can we
>> do that?
> 
> I've no idea what you're talking about here, sorry.  What are
> "this" and "the patch"?  Surely you can just add whatever DT
> changes you need to add without the thing that uses the bindings?

When booting Harmony using device tree, there's a special case that
registers all the regulators using the remnants of the Harmony board
file. Hence, regulators work right now even without the DT
instantiating them.

The patch in this thread adds all the required regulators to the DT
file. However, it should also remove the special case so the
regulators don't get registered twice, once from the board file and
once from DT. However, doing that would prevent regulators getting
registered at all, since v3.6-rc* don't have all the required
(TPS6586x) regulator (driver) patches to get the regulators
instantiated from DT. Everything will only work in linux-next or
sometime during the 3.7 merge window.  Hence, git bisect would be broken.

One solution to this is to bring the regulator tree into the Tegra
tree as a dependency, and then apply a patch which adds the regulators
to DT, and removes the special case from the board file. I'm asking
for your OK to do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/