linux-kernel - Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for vt8500-serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120821231255.71a7515a@pyramind.ukuu.org.uk>
Date:	Tue, 21 Aug 2012 23:12:55 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Tony Prisk <linux@...sktech.co.nz>
Cc:	vt8500-wm8505-linux-kernel@...glegroup.com,
	Russell King <linux@....linux.org.uk>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Alan Cox <alan@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Arnd Bergmann <arnd@...db.de>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Mike Turquette <mturquette@...com>,
	Stephen Warren <swarren@...dia.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-fbdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-serial@...r.kernel.org, rtc-linux@...glegroups.com,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for
 vt8500-serial

On Wed, 22 Aug 2012 08:47:32 +1200
Tony Prisk <linux@...sktech.co.nz> wrote:

> Signed-off-by: Tony Prisk <linux@...sktech.co.nz>
> ---
>  drivers/tty/serial/vt8500_serial.c |   37 ++++++++++++++++++++++++++++++++----
>  1 file changed, 33 insertions(+), 4 deletions(-)

Can we have a comment attached to a change this size. In particular one
describing why it gone from 4 to 6 ports, and why the port id twiddling.

Is there a reason you can't use the device tree port id ?

What are the regression risks for existing users expecting the pdev->id
binding ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/