linux-kernel - Re: [PATCH] memory-hotplug: add build zonelists when offline pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50347906.4030101@cn.fujitsu.com>
Date:	Wed, 22 Aug 2012 14:15:34 +0800
From:	Wen Congyang <wency@...fujitsu.com>
To:	qiuxishi <qiuxishi@...il.com>
CC:	akpm@...ux-foundation.org, liuj97@...il.com,
	paul.gortmaker@...driver.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, bessel.wang@...wei.com,
	wujianguo@...wei.com, qiuxishi@...wei.com, jiang.liu@...wei.com,
	guohanjun@...wei.com, chenkeping@...wei.com, yinghai@...nel.org
Subject: Re: [PATCH] memory-hotplug: add build zonelists when offline pages

At 08/21/2012 08:51 PM, qiuxishi Wrote:
> From: Xishi Qiu <qiuxishi@...wei.com>
> 
> online_pages() does build_all_zonelists() and zone_pcp_update(),
> I think offline_pages() should do it too. The node has no memory
> to allocate, so remove this node's zones form other nodes' zonelists.
> 
> 
> Signed-off-by: Xishi Qiu <qiuxishi@...wei.com>
> ---
>  mm/memory_hotplug.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index bc7e7a2..5172bd4 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -979,7 +979,11 @@ repeat:
>  	if (!node_present_pages(node)) {
>  		node_clear_state(node, N_HIGH_MEMORY);
>  		kswapd_stop(node);
> -	}
> +		mutex_lock(&zonelists_mutex);
> +		build_all_zonelists(NODE_DATA(node), NULL);

The node is still onlined now, so there is no need to pass
this node's pgdat to build_all_zonelists().

I think we should build all zonelists when the zone has no
pages.

> +		mutex_unlock(&zonelists_mutex);
> +	} else
> +		zone_pcp_update(zone);

There is more than one zone in a node. So the zone can have
no pages when the node has some pages.

And we have called drain_all_pages(), I think there is no need
to call zone_pcp_update() here.

Thanks
Wen Congyang

> 
>  	vm_total_pages = nr_free_pagecache_pages();
>  	writeback_set_ratelimit();

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/