linux-kernel - RE: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Aug 2012 20:11:08 +0000
From:	"Mingarelli, Thomas" <Thomas.Mingarelli@...com>
To:	Wim Van Sebroeck <wim@...ana.be>, Andi Kleen <andi@...stfloor.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"mmarek@...e.cz" <mmarek@...e.cz>,
	"linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
	"JBeulich@...e.com" <JBeulich@...e.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>
Subject: RE: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global

I am OK with the changes. We have a few more coming soon to improve the kdump process when hpwdt is running. Just a heads up.


Thanks,
Tom

-----Original Message-----
From: wimvs@...001.leaseweb.com [mailto:wimvs@...001.leaseweb.com] On Behalf Of Wim Van Sebroeck
Sent: Wednesday, August 22, 2012 2:25 PM
To: Andi Kleen
Cc: linux-kernel@...r.kernel.org; x86@...nel.org; mmarek@...e.cz; linux-kbuild@...r.kernel.org; JBeulich@...e.com; akpm@...ux-foundation.org; Andi Kleen; Mingarelli, Thomas
Subject: Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global

Hi andi,

> From: Andi Kleen <ak@...ux.intel.com>
> 
> We cannot assume that the inline assembler code always ends up
> in the same file as the original C file. So make any assembler labels
> that are called with "extern" by C global
> 
> Cc: wim@...ana.be
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

You have my signed-off-by, but I'm Cc-ing also the author of the driver
(Tom Mingarelli) so that he is also aware of the proposed change.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/