linux-kernel - Re: [PATCH 2/2] fat : no need to reset EOF in ent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878vd1wy39.fsf@devron.myhome.or.jp>
Date:	Sun, 26 Aug 2012 23:02:18 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Amit Sahrawat <amit.sahrawat83@...il.com>
Subject: Re: [PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32

Namjae Jeon <linkinjeon@...il.com> writes:

> #define FAT_ENT_EOF(EOF_FAT32)
>
> there is no need to reset value of 'new' for FAT32 as the values is
> already correct
>
> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@...il.com>
> ---
>  fs/fat/fatent.c |    2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
> index 31f08ab..af53815 100644
> --- a/fs/fat/fatent.c
> +++ b/fs/fat/fatent.c
> @@ -186,8 +186,6 @@ static void fat16_ent_put(struct fat_entry *fatent, int new)
>  
>  static void fat32_ent_put(struct fat_entry *fatent, int new)
>  {
> -	if (new == FAT_ENT_EOF)
> -		new = EOF_FAT32;
>  

Please remove this new line too. If it was removed,

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

>  	WARN_ON(new & 0xf0000000);
>  	new |= le32_to_cpu(*fatent->u.ent32_p) & ~0x0fffffff;

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/