linux-kernel - Re: [PATCH 3/3] fat: simplify writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874nnpwxxl.fsf@devron.myhome.or.jp>
Date:	Sun, 26 Aug 2012 23:05:42 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Amit Sahrawat <amit.sahrawat83@...il.com>
Subject: Re: [PATCH 3/3] fat: simplify writeback_inode function.

Namjae Jeon <linkinjeon@...il.com> writes:

> Simplify writeback_inode function.

Looks cleanup without logic change.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@...il.com>
> ---
>  fs/fat/inode.c |   14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 973296b..4bbb24e 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1457,18 +1457,14 @@ static int writeback_inode(struct inode *inode)
>  {
>  
>  	int ret;
> -	struct address_space *mapping = inode->i_mapping;
> -	struct writeback_control wbc = {
> -	       .sync_mode = WB_SYNC_NONE,
> -	      .nr_to_write = 0,
> -	};
> -	/* if we used WB_SYNC_ALL, sync_inode waits for the io for the
> -	* inode to finish.  So WB_SYNC_NONE is sent down to sync_inode
> +
> +	/* if we used wait=1, sync_inode_metadata waits for the io for the
> +	* inode to finish.  So wait=0 is sent down to sync_inode_metadata
>  	* and filemap_fdatawrite is used for the data blocks
>  	*/
> -	ret = sync_inode(inode, &wbc);
> +	ret = sync_inode_metadata(inode, 0);
>  	if (!ret)
> -	       ret = filemap_fdatawrite(mapping);
> +	       ret = filemap_fdatawrite(inode->i_mapping);
>  	return ret;
>  }

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/