linux-kernel - Re: [PATCH] clk.h: Fix shim ifdef guard (HAVE_CLK -> COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120828005100.GG25321@flint.arm.linux.org.uk>
Date:	Tue, 28 Aug 2012 01:51:00 +0100
From:	Russell King <rmk@....linux.org.uk>
To:	Jeff Mahoney <jeffm@...e.com>
Cc:	Linux Kernel Maling List <linux-kernel@...r.kernel.org>,
	Viresh Kumar <viresh.kumar@...com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jeff Garzik <jgarzik@...hat.com>, Andrew Lunn <andrew@...n.ch>,
	Bhupesh Sharma <bhupesh.sharma@...com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Mike Turquette <mturquette@...aro.org>,
	Sergei Shtylyov <sshtylyov@...mvista.com>
Subject: Re: [PATCH] clk.h: Fix shim ifdef guard (HAVE_CLK -> COMMON_CLK)

On Mon, Aug 27, 2012 at 04:53:44PM -0400, Jeff Mahoney wrote:
> Should the clk_devm stuff be moved someplace generic? I don't have a
> horse in this race. My only interest here is to get these configs to
> build again. :)

devm_clk_get() should not be in clkdev.c, but should be entirely separate,
allowing anyone who is using the clk API to use it.  But unfortunately,
that's not how it ended up getting added...  Moving it is something that's
on my very long todo list.

It should still remain in drivers/clk, but it should be in a separate file,
probably built conditionally by HAVE_CLK being defined.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/