| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Aug 2012 10:29:35 -0400 From: Huang Shijie <shijie8@...il.com> To: dedekind1@...il.com Cc: dwmw2@...radead.org, linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, shmulik.ladkani@...il.com Subject: Re: [PATCH 2/3] mtd: cmdlinepart: sort the unsorted partitions On Fri, Aug 31, 2012 at 9:59 AM, Artem Bityutskiy <dedekind1@...il.com> wrote: > On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: >> Assume we have a 1GB(8Gb) nand chip. >> It is legit if we set the partitions as the following: >> gpmi-nand:1g@...m(rootfs),100m@0(boot),100m@...m(kernel) >> >> But the current code can not parse out any partition with this >> cmdline. >> >> This patch sorts the unsorted partitions by the @offset. >> For there are maybe only several partitions, i use the simple >> Bubble sort algorithm. >> >> Signed-off-by: Huang Shijie <shijie8@...il.com> > > I still cannot find time to actually think about this carefully, but the > commit message does not sound convincing, it does not explain why > sorting is the right way to fix the issue, and what would be the > alternatives. It actually also does not explain why exactly we currently > cannot parse the example string. > thanks . I will add more comment in the next version. Best Regards Huang Shijie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists