linux-kernel - Re: [PATCH 0/2] mfd: twl: Move PWM driver to PWM framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Sep 2012 11:11:56 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Thierry Reding <thierry.reding@...onic-design.de>
CC:	Samuel Ortiz <sameo@...ux.intel.com>, NeilBrown <neilb@...e.de>,
	Benoit Cousson <b-cousson@...com>, Felipe Balbi <balbi@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] mfd: twl: Move PWM driver to PWM framework

Hi,

On 09/02/2012 01:40 PM, Thierry Reding wrote:
> Hi,
> 
> This mini series replaces the twl_has_*() macros by the equivalent
> standard IS_ENABLED() macro and moves the PWM driver to the PWM
> framework.
> 
> I'll take the second patch through the PWM tree but would like to have
> some Acked-bys from people that know and have the hardware and can
> verify that I haven't broken anything.

All looks good for me but I have one comment for patch 2.

> 
> Thierry
> 
> Thierry Reding (2):
>   mfd: twl: Replace twl_has_*() macros by IS_ENABLED()
>   pwm: Move TWL6030 PWM driver to PWM framework
> 
>  drivers/mfd/Kconfig       |  10 ---
>  drivers/mfd/Makefile      |   1 -
>  drivers/mfd/twl-core.c    | 124 ++++++++-----------------------
>  drivers/mfd/twl6030-pwm.c | 165 -----------------------------------------
>  drivers/pwm/Kconfig       |   9 +++
>  drivers/pwm/Makefile      |   1 +
>  drivers/pwm/pwm-twl6030.c | 184 ++++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 226 insertions(+), 268 deletions(-)
>  delete mode 100644 drivers/mfd/twl6030-pwm.c
>  create mode 100644 drivers/pwm/pwm-twl6030.c
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/