linux-kernel - Re: [PATCH v4 3/3] avr32: at32ap700x: set DMA slave properties for MCI dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdLkUZraD5AR5zT32Fs+Eh9vC+DT1BE3Ebd_QASAX+jEQ@mail.gmail.com>
Date:	Mon, 3 Sep 2012 11:28:42 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Hein Tibosch <hein_tibosch@...oo.es>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	viresh kumar <viresh.kumar@...aro.org>,
	Hans-Christian Egtvedt <egtvedt@...fundet.no>,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	"ludovic.desroches" <ludovic.desroches@...el.com>,
	Havard Skinnemoen <havard@...nnemoen.net>,
	spear-devel <spear-devel@...t.st.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] avr32: at32ap700x: set DMA slave properties for
 MCI dw_dmac

On Sun, Sep 2, 2012 at 8:54 PM, Hein Tibosch <hein_tibosch@...oo.es> wrote:
> --- a/arch/avr32/mach-at32ap/at32ap700x.c
> +++ b/arch/avr32/mach-at32ap/at32ap700x.c
> @@ -1355,6 +1355,10 @@ at32_add_device_mci(unsigned int id, struct mci_platform_data *data)
>                                 | DWC_CFGH_DST_PER(1));
>         slave->sdata.cfg_lo &= ~(DWC_CFGL_HS_DST_POL
>                                 | DWC_CFGL_HS_SRC_POL);
> +       /* Setup DMA controller: let source be master */
> +       slave->sdata.src_master = 1;
I don't know the details, but do you want to set up dst_master as well?

> +       /* Limit maximum transfer width to 32-bit */
> +       slave->sdata.max_mem_width = DW_MEM_WIDTH_32;
It's under question regarding to my comments on previous patch.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/