linux-kernel - Re: [PATCH] ARM: S3C24XX: Add WIZnet W5300E01-ARM board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOkfWjeDY2nh2vZoNZVc7PFKjmqCdbSMjnJVntT2uQPHoJ8Uxg@mail.gmail.com>
Date:	Tue, 4 Sep 2012 00:39:00 +0900
From:	Taehun Kim <kth3321@...il.com>
To:	Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:	Vasily Khoruzhick <anarsoul@...il.com>,
	Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: S3C24XX: Add WIZnet W5300E01-ARM board support

2012/9/3 Sylwester Nawrocki <s.nawrocki@...sung.com>:
> Hi,
>
> On 09/03/2012 09:56 AM, Vasily Khoruzhick wrote:
>>> +static void __init w5300e01_init(void)
>>> +{
>>> +       s3c_nand_set_platdata(&w5300e01_nand_info);
>>> +       platform_add_devices(w5300e01_devices, ARRAY_SIZE(w5300e01_devices));
>>> +
>>> +       /* W5300 interrupt pin. */
>>> +       s3c2410_gpio_cfgpin(S3C2410_GPF(0), S3C2410_GPIO_IRQ);
>>> +
>>> +       s3c2410_gpio_cfgpin(S3C2410_GPF(4), S3C2410_GPIO_OUTPUT);
>>> +       s3c2410_gpio_cfgpin(S3C2410_GPF(5), S3C2410_GPIO_OUTPUT);
>>> +       s3c2410_gpio_cfgpin(S3C2410_GPF(6), S3C2410_GPIO_OUTPUT);
>>> +       s3c2410_gpio_cfgpin(S3C2410_GPF(7), S3C2410_GPIO_OUTPUT);
>>> +
>>> +       s3c2410_gpio_setpin(S3C2410_GPF(0), 1);
>>> +       s3c2410_gpio_setpin(S3C2410_GPF(4), 1);
>>> +       s3c2410_gpio_setpin(S3C2410_GPF(5), 1);
>>> +       s3c2410_gpio_setpin(S3C2410_GPF(6), 1);
>>> +       s3c2410_gpio_setpin(S3C2410_GPF(7), 1);
>>> +
>>
>> Please use gpiolib API, legacy s3c2410_gpio_* API will be removed soon.
>
> Right, you'll find some information about this in
> Documentation/arm/Samsung-S3C24XX/GPIO.txt.
>
> These links may be useful as well:
> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg11985.html
> http://www.spinics.net/lists/arm-kernel/msg192119.html
>
> --
>
> Regards,
> Sylwester

Thank you for the feedback. I will rewrite the gpio functions and
propose the new patch soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/