[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120904113545.GD4657@jack.whiskey>
Date: Tue, 4 Sep 2012 13:35:45 +0200
From: Andi Shyti <andi@...zian.org>
To: Dong Aisheng <b29396@...escale.com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linus.walleij@...ricsson.com, s.hauer@...gutronix.de,
shawn.guo@...aro.org, kernel@...gutronix.de,
grant.likely@...retlab.ca, rob.herring@...xeda.com,
sameo@...ux.intel.com, lrg@...com,
broonie@...nsource.wolfsonmicro.com, richard.zhao@...escale.com,
devicetree-discuss@...ts.ozlabs.org, swarren@...dotorg.org
Subject: Re: [PATCH v5 1/4] mfd: add syscon driver based on regmap
Hi Dong,
On Tue, Sep 04, 2012 at 11:20:08AM +0800, Dong Aisheng wrote:
> +static int __devinit syscon_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
Do we really need this variable? Anyway you are using it only
once in the dev_info.
> + struct device_node *np = dev->of_node;
> + struct syscon *syscon;
> + struct resource res;
> + int ret;
> +
> + if (!np)
> + return -ENOENT;
> +
> + syscon = devm_kzalloc(&pdev->dev, sizeof(struct syscon),
> + GFP_KERNEL);
> + if (!syscon)
> + return -ENOMEM;
> +
> + syscon->base = of_iomap(np, 0);
> + if (!syscon->base)
> + return -EADDRNOTAVAIL;
> +
> + ret = of_address_to_resource(np, 0, &res);
> + if (ret)
> + return ret;
> +
> + syscon_regmap_config.max_register = res.end - res.start - 3;
> + syscon->regmap = devm_regmap_init_mmio(&pdev->dev, syscon->base,
> + &syscon_regmap_config);
> + if (IS_ERR(syscon->regmap)) {
> + dev_err(&pdev->dev, "regmap init failed\n");
> + return PTR_ERR(syscon->regmap);
> + }
> +
> + syscon->dev = &pdev->dev;
> + platform_set_drvdata(pdev, syscon);
> +
> + dev_info(dev, "syscon regmap start 0x%x end 0x%x registered\n",
> + res.start, res.end);
> +
> + return 0;
in case of error you are not freeing syscon.
Moreover, in my opinion, some dev_err more should not heart
Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists