lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120904114059.GC12901@arwen.pp.htv.fi>
Date:	Tue, 4 Sep 2012 14:41:01 +0300
From:	Felipe Balbi <balbi@...com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
Cc:	Felipe Balbi <balbi@...com>, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 1/4] i2c: introduce i2c-cbus driver

Hi,

On Tue, Sep 04, 2012 at 12:31:42PM +0300, Aaro Koskinen wrote:
> On Tue, Sep 04, 2012 at 12:05:07PM +0300, Felipe Balbi wrote:
> > > + * CBUS I2C driver for Nokia Internet Tablets.
> 
> [...]
> 
> > this version misses the entire IRQ handling we already had on linux-omap
> > tree, so it's quite a regression.
> 
> There's no interrupts used in plain CBUS protocol/communication I think?
> 
> But Retu MFD supports the GPIO IRQ. I added the code for this set. And
> the power button driver (patch 4/4) is using this functionality:
> 
> # cat /proc/interrupts
> [...]
> 204:         29      GPIO  retu-mfd
> 224:         29      RETU  retu-pwrbutton

oops, indeed. My bad. I looked at the wrong patch. Nevermind, this
series looks good to me.

FWIW:

Acked-by: Felipe Balbi <balbi@...com>

(for entire series)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ