linux-kernel - Re: [PATCH 2/2] numa: don't check if node is NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120904161102.143ceb6d.akpm@linux-foundation.org>
Date:	Tue, 4 Sep 2012 16:11:02 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Wen Congyang <wency@...fujitsu.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	x86@...nel.org, linux-pm@...r.kernel.org, len.brown@...el.com,
	pavel@....cz, rjw@...k.pl, tglx@...utronix.de,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, rusty@...tcorp.com.au,
	bhelgaas@...gle.com, David Rientjes <rientjes@...gle.c>
Subject: Re: [PATCH 2/2] numa: don't check if node is NUMA_NO_NODE

On Mon, 03 Sep 2012 16:12:12 +0800
Wen Congyang <wency@...fujitsu.com> wrote:

> If we don't debug per_cpu maps, the cpu's node is stored in per_cpu variable
> numa_node. If node is NUMA_NO_NODE, it means the caller want to clear the
> cpu's node. So we should also call set_cpu_numa_node() in this case.

The changelog is missing important information.

What is the runtime effect of the patch?  In other words, please fully
describe the runtime effects of the bug which the patch fixed.

Please always provide this information.  It will help others decide
which kernel version(s) should be patched, and will help the
maintainers of other kernel trees (especially vendor trees) to work out
whether they should backport the fix into their kernels.

> --- a/arch/x86/mm/numa.c
> +++ b/arch/x86/mm/numa.c
> @@ -97,8 +97,7 @@ void __cpuinit numa_set_node(int cpu, int node)
>  #endif
>  	per_cpu(x86_cpu_to_node_map, cpu) = node;
>  
> -	if (node != NUMA_NO_NODE)
> -		set_cpu_numa_node(cpu, node);
> +	set_cpu_numa_node(cpu, node);
>  }
>  
>  void __cpuinit numa_clear_node(int cpu)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/