[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120905054459.GB12521@in.ibm.com>
Date: Wed, 5 Sep 2012 11:15:00 +0530
From: Ananth N Mavinakayanahalli <ananth@...ibm.com>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: ppcdev <linuxppc-dev@...ts.ozlabs.org>,
lkml <linux-kernel@...r.kernel.org>,
Paul Mackerras <paulus@...ba.org>,
Anton Blanchard <anton@...ba.org>,
Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
peterz@...radead.org, michael@...erman.id.au,
Ingo Molnar <mingo@...e.hu>, oleg@...hat.com
Subject: Re: [PATCH v5 3/3] powerpc: Uprobes port to powerpc
On Wed, Sep 05, 2012 at 03:26:59PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2012-08-24 at 13:01 +0530, Ananth N Mavinakayanahalli wrote:
> > From: Ananth N Mavinakayanahalli <ananth@...ibm.com>
> >
> > This is the port of uprobes to powerpc. Usage is similar to x86.
>
> Guys, can you do a minimum of build testing ?
>
> This one breaks due to uprobe_get_swbp_addr() being defined in both
> asm and include/linux when CONFIG_UPROBE isn't set. You don't need
> to define it at all in fact, the generic code takes care of both the
> declaration for CONFIG_UPROBE and the empty inline for !CONFIG_UPROBE.
>
> I'm fixing that one up myself but please, please, get yourself a test
> build script or something to make sure you don't at least break the
> build when the stuff you're adding isn't enabled (among others).
Sorry Ben. That was an oversight. Won't happen again.
Regards,
Ananth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists