linux-kernel - Re: [RFC,PATCH v2] efi: Add support for a UEFI variable filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1346941851.4244.87.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Thu, 06 Sep 2012 15:30:51 +0100
From:	Matt Fleming <matt.fleming@...el.com>
To:	Jeremy Kerr <jeremy.kerr@...onical.com>
Cc:	linux-kernel@...r.kernel.org, Matthew Garrett <mjg@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Matt Domsch <Matt_Domsch@...l.com>,
	Peter Jones <pjones@...hat.com>
Subject: Re: [RFC,PATCH v2] efi: Add support for a UEFI variable filesystem

(Cc'ing Peter Jones who wrote a auth deletion patch for efivars)

On Thu, 2012-09-06 at 22:23 +0800, Jeremy Kerr wrote:
> Hi Matt,
> 
> > Am I correct in thinking that this filesystem doesn't handle deletion of
> > authenticated variables?
> 
> Unless I'm missing something, this should work fine; we just pass the 
> EFI_VARIABLE_AUTHENTICATION_2 descriptor (with the usual attribute 
> header), but no data following the descriptor.

I think this is the problematic chunk of code,

static int efivars_unlink(struct inode *dir, struct dentry *dentry)             
{                                                                               
        struct efivar_entry *var = dentry->d_inode->i_private;                  
        struct efivars *efivars = var->efivars;                                 
        efi_status_t status;                                                    
                                                                                
        spin_lock(&efivars->lock);                                              
                                                                                
        status = efivars->ops->set_variable(var->var.VariableName,              
                                            &var->var.VendorGuid,               
                                            0, 0, NULL);                        

For deleting authenticated variables Attributes, DataSize and Data need
to be non-zero. I think DataSize == AuthInfo descriptor. Peter?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/