linux-kernel - Re: [PATCH 07/12] perf diff: Add ratio computation way to compare hist entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120907092632.GA3411@krava.brq.redhat.com>
Date:	Fri, 7 Sep 2012 11:26:32 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Andi Kleen <andi@...stfloor.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 07/12] perf diff: Add ratio computation way to compare
 hist entries

On Fri, Sep 07, 2012 at 02:45:28PM +0900, Namhyung Kim wrote:
> On Thu,  6 Sep 2012 17:47:01 +0200, Jiri Olsa wrote:
> > Adding -c option to select computation method with the current
> > 'Delta' computation as default. Current posible values are of
> > this option are: 'delta' and 'ratio'.
> >

SNIP

> > @@ -263,6 +296,8 @@ static const struct option options[] = {
> >  		    "Show position displacement relative to baseline"),
> >  	OPT_BOOLEAN('b', "baseline-only", &show_baseline_only,
> >  		    "Show only items with match in baseline"),
> > +	OPT_STRING('c', "compute", &compute_str, "delta,ratio (default delta)",
> > +		   "Entries differential computation selection"),
> 
> Why not make it OPT_CALLBACK?
> 
right, thanks

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/