[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120907093004.GC3411@krava.brq.redhat.com>
Date: Fri, 7 Sep 2012 11:30:04 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: linux-kernel@...r.kernel.org,
Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@...il.com>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
Andi Kleen <andi@...stfloor.org>,
David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 11/12] perf diff: Add -F option to display formula for
computation
On Fri, Sep 07, 2012 at 03:02:37PM +0900, Namhyung Kim wrote:
> On Thu, 6 Sep 2012 17:47:05 +0200, Jiri Olsa wrote:
> > Adding -F option to display the formula for specified computation.
> > This is mainly to facilitate debuging, but can be usefull anyway.
> >
SNIP
> > @@ -175,6 +182,7 @@ DEF_COLUMN(delta, HISTC_DELTA, 8, "Delta")
> > DEF_COLUMN(ratio, HISTC_RATIO, 14, "Ratio")
> > DEF_COLUMN(wdiff, HISTC_WEIGHTED_DIFF, 13, "Weighted diff")
> > DEF_COLUMN(displacement, HISTC_DISPLACEMENT, 5, "Displ")
> > +DEF_COLUMN(formula_wdiff, HISTC_FORMULA_WEIGHTED_DIFF, 50, "Formula")
>
> This fixed 50 column width looks too large to me. What about make it
> dynamic like sort_list?
ok, good idea
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists