linux-kernel - Re: [PATCH 2/2] pwm: Move TWL6030 PWM driver to PWM framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120907131748.GE29340@avionic-0098.mockup.avionic-design.de>
Date:	Fri, 7 Sep 2012 15:17:48 +0200
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, NeilBrown <neilb@...e.de>,
	Benoit Cousson <b-cousson@...com>, Felipe Balbi <balbi@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pwm: Move TWL6030 PWM driver to PWM framework

On Mon, Sep 03, 2012 at 11:15:27AM +0300, Peter Ujfalusi wrote:
> On 09/02/2012 01:40 PM, Thierry Reding wrote:
> > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> > index 5fbb2a6..1b1a789 100644
> > --- a/drivers/mfd/twl-core.c
> > +++ b/drivers/mfd/twl-core.c
> > @@ -638,6 +638,13 @@ add_children(struct twl4030_platform_data *pdata, unsigned irq_base,
> >  			return PTR_ERR(child);
> >  	}
> >  
> > +	if (IS_ENABLED(CONFIG_PWM_TWL6030)) {
> 
> I think you should also check for the PMIC versions here before adding the child:
> 	if (IS_ENABLED(CONFIG_PWM_TWL6030) && twl_class_is_6030()) {
> 
> To avoid loading the twl6030-pwm driver for twl4030 class.

Yes, that does make sense. I'll add it.

Thierry

Content of type "application/pgp-signature" skipped