[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <504DD7B5.40908@ti.com>
Date: Mon, 10 Sep 2012 17:36:13 +0530
From: Prabhakar Lad <prabhakar.lad@...com>
To: Sekhar Nori <nsekhar@...com>
CC: Prabhakar Lad <prabhakar.csengg@...il.com>,
dlos <davinci-linux-open-source@...ux.davincidsp.com>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] ARM: da850/omap-l138: Add EVM specific code for
VPIF to work
Hi Sekhar,
On Monday 10 September 2012 02:57 PM, Sekhar Nori wrote:
> Hi Prabhakar,
>
> On 9/7/2012 11:04 PM, Prabhakar Lad wrote:
>> On Fri, Sep 7, 2012 at 10:48 PM, Sekhar Nori <nsekhar@...com> wrote:
>
>>>> +static struct vpif_subdev_info da850_vpif_capture_sdev_info[] = {
>>>> +#if defined(CONFIG_DA850_UI_SD_VIDEO_PORT)
>>>
>>> You agreed to get rid of these multiple ifdefs but you have not fixed that.
>>>
>> I have merged the top one, at later stage when we go ahead and add sensor
>> support then we would have require to have define two
>> da850_vpif_capture_sdev_info
>> so to avoid it I have kept this one.
>
> Lets get to that when we actually add sensor support. It might make
> sense then. Right now, there is no reason to have them.
>
Ok I'll fix it for v3.
Regards,
--Prabhakar
> Thanks,
> Sekhar
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists