linux-kernel - Re: [PATCH 16/19] mfd: Provide the tc3589x with its own IRQ domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaAwaUwr9njGCRDssyNVFv8TgeZeKVeFj=MUA_fA_jesw@mail.gmail.com>
Date:	Mon, 10 Sep 2012 06:05:13 -0700
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com,
	arnd@...db.de, Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 16/19] mfd: Provide the tc3589x with its own IRQ domain

On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@...aro.org> wrote:

> In preparation for Device Tree enablement all IRQ controllers
> should control their own IRQ domain. This patch provides just
> that.
>
> CC: Samuel Ortiz <sameo@...ux.intel.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

It's always nice to have irqdomains added, excellent patch!

> +       if (base) {
> +               tc3589x->domain = irq_domain_add_legacy(
> +                       NULL, TC3589x_NR_INTERNAL_IRQS, base,
> +                       0, &tc3589x_irq_ops, tc3589x);
>         }
> +       else {
> +               tc3589x->domain = irq_domain_add_linear(
> +                       NULL, TC3589x_NR_INTERNAL_IRQS,
> +                       &tc3589x_irq_ops, tc3589x);
> +       }

This is especially elegant, well done.
Not my subsystem, but FWIW:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/