linux-kernel - Re: [PATCH 06/14] tty/serial/core: Introduce poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120910175725.GA13673@lizard>
Date:	Mon, 10 Sep 2012 10:57:25 -0700
From:	Anton Vorontsov <anton.vorontsov@...aro.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Russell King <linux@....linux.org.uk>,
	Jason Wessel <jason.wessel@...driver.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Cox <alan@...ux.intel.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Colin Cross <ccross@...roid.com>,
	Brian Swetland <swetland@...gle.com>,
	John Stultz <john.stultz@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linaro-kernel@...ts.linaro.org, patches@...aro.org,
	kernel-team@...roid.com, kgdb-bugreport@...ts.sourceforge.net,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH 06/14] tty/serial/core: Introduce poll_init callback

On Mon, Sep 10, 2012 at 12:13:20PM +0100, Alan Cox wrote:
> > +	tport = &state->port;
> > +	if (!(tport->flags & ASYNC_INITIALIZED) && port->ops->poll_init) {
> > +		mutex_lock(&tport->mutex);
> > +		ret = port->ops->poll_init(port);
> > +		/*
> > +		 * We don't set ASYNCB_INITIALIZED as we only initialized the
> > +		 * hw, e.g. state->xmit is still uninitialized.
> > +		 */
> > +		mutex_unlock(&tport->mutex);
> > +		if (ret)
> > +			return ret;
> > +	}
> 
> What stops a parallel open or close changing ASYNC_INITIALIZED after you
> test and before you lock ?

Yeah, I should do the whole thing under the mutex.

Not related to this particular issue, but the fact that close() can powerdown
the hardware is quite bad. Today it is always possible to use open,close
sequence on /dev/ttyXXXX, and polling would break if close() deinitializes the
hardware (e.g. via uart_change_pm()).

In console= case, serial core handles the issue via uart_console(), checking if
the port is used for console, preventing it to power down the hardware. We can
do the same, or make tty_find_polling_driver() refcount individual ports/lines.
But the issue is orthogonal to this particular patch, although needs to be
fixed some day.

Thanks!

Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/