linux-kernel - Re: [PATCH v3] can: rename LED trigger name on netdev renames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120911071314.GA4766@gmail.com>
Date:	Tue, 11 Sep 2012 09:13:14 +0200
From:	Fabio Baltieri <fabio.baltieri@...il.com>
To:	Oliver Hartkopp <socketcan@...tkopp.net>
Cc:	Kurt Van Dijck <kurt.van.dijck@....be>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	linux-kernel@...r.kernel.org, linux-can@...r.kernel.org
Subject: Re: [PATCH v3] can: rename LED trigger name on netdev renames

Hi Oliver,

On Tue, Sep 11, 2012 at 07:42:19AM +0200, Oliver Hartkopp wrote:
> On 10.09.2012 22:08, Kurt Van Dijck wrote:
> > But the initial name must have been set properly already in that case...
> 
> Yes it is.
> 
> See register_netdevice()
> 
> http://lxr.linux.no/#linux+v3.5.3/net/core/dev.c#L5453
> 
> 
> at the end NETDEV_REGISTER is notified:
> 
> http://lxr.linux.no/#linux+v3.5.3/net/core/dev.c#L5552
> 
> So it would be pretty elegant to create the LED trigger name in the notifier.
> This would allow to remove that code at the current init function too.

That would indeed be elegant, but in the current implementation
triggers only works for supported drivers, while putting registration in
the notifier would imply to use it also in unsupported ones, where you
would get a trigger which never triggers.

Is that what you had in mind?

Of course that would simplify another bit trigger integration to the
driver... if the target is to have support for all drivers that's a good
thing, through I think that triggers are mostly useful on embedded drivers.

Cheers,
Fabio

-- 
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/