linux-kernel - Re: [PATCH v3] can: rename LED trigger name on netdev renames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120911080535.GA412@vandijck-laurijssen.be>
Date:	Tue, 11 Sep 2012 10:05:35 +0200
From:	Kurt Van Dijck <kurt.van.dijck@....be>
To:	Oliver Hartkopp <socketcan@...tkopp.net>,
	Fabio Baltieri <fabio.baltieri@...il.com>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	linux-kernel@...r.kernel.org, linux-can@...r.kernel.org
Subject: Re: [PATCH v3] can: rename LED trigger name on netdev renames

On Mon, Sep 10, 2012 at 10:08:44PM +0200, Kurt Van Dijck wrote:
> On Mon, Sep 10, 2012 at 09:01:21PM +0200, Oliver Hartkopp wrote:
> > On 10.09.2012 20:40, Fabio Baltieri wrote:
> > 
> > > On Mon, Sep 10, 2012 at 08:25:50PM +0200, Oliver Hartkopp wrote:
> > >> On 10.09.2012 16:28, Kurt Van Dijck wrote:
> > >>> Fabio,
> > >>>
> > > 
> > > Also, I noticed you removed the namespace check... wasn't it needed?
> > > (just asking, I have no idea).
> 

Moreover, the function tests if the net_device has an associated can_priv.
The namespace it's in is irrelevant then?
I think those tests may be removed in af_can too.

Kurt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/