linux-kernel - Re: [PATCH 1/3] tracing,x86: add a TSC trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJL_ekvGkVpK_v2ztZPoES_R+odjEJXbxuR7LZs6Q_dTNJJpfg@mail.gmail.com>
Date:	Wed, 12 Sep 2012 11:48:29 -0700
From:	David Sharp <dhsharp@...gle.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [PATCH 1/3] tracing,x86: add a TSC trace_clock; reset buffer on
 clock change

On Tue, Sep 11, 2012 at 8:48 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Tue, 2012-09-11 at 19:41 -0700, David Sharp wrote:
>> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
>> index 5c38c81..dc1f1fa 100644
>> --- a/kernel/trace/trace.c
>> +++ b/kernel/trace/trace.c
>> @@ -480,6 +480,9 @@ static struct {
>>       { trace_clock_local,    "local" },
>>       { trace_clock_global,   "global" },
>>       { trace_clock_counter,  "counter" },
>> +#ifdef CONFIG_X86_TSC
>> +     { trace_clock_tsc,      "tsc" },
>> +#endif
>>  };
>
> I really hate adding arch defs in generic code. Perhaps what we could do
> is add a define here. Something like:
>
> #ifndef ARCH_TRACE_CLOCKS
> # define ARCH_TRACE_CLOCKS
> #endif
>
> [...]
>         { trace_clock_counter, "counter" },
>         ARCH_TRACE_CLOCKS
> };
>
> and have ARCH_TRACE_CLOCKS defined somewhere in an arch specific header.
> Not sure what header we could use though :-/
>
> That is, in a header have:
>
> #define ARCH_TRACE_CLOCKS \
>         { trace_clock_x86_tsc,  "tsc" },
>
> and also define trace_clock_x86_tsc in arch/x86/kernel...

Good point. I'll figure out somewhere better to put it...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/