linux-kernel - Re: [PATCH] of: specify initrd location using 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5051816A.3050705@linutronix.de>
Date:	Thu, 13 Sep 2012 08:47:06 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Rob Herring <robherring2@...il.com>
CC:	Cyril Chemparathy <cyril@...com>, linux-mips@...ux-mips.org,
	x86@...nel.org, a-jacquiot@...com, mahesh@...ux.vnet.ibm.com,
	linus.walleij@...aro.org, grant.likely@...retlab.ca,
	paul.gortmaker@...driver.com, paulus@...ba.org, hpa@...or.com,
	m.szyprowski@...sung.com, jonas@...thpole.se,
	linux@....linux.org.uk, linux-c6x-dev@...ux-c6x.org,
	nico@...aro.org, david.daney@...ium.com, mingo@...hat.com,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	benh@...nel.crashing.org, suzuki@...ibm.com, linux@...nrisc.net,
	arnd@...db.de, microblaze-uclinux@...e.uq.edu.au,
	devicetree-discuss@...ts.ozlabs.org, msalter@...hat.com,
	rob.herring@...xeda.com, tglx@...utronix.de,
	linux-arm-kernel@...ts.infradead.org, blogic@...nwrt.org,
	dhowells@...hat.com, monstr@...str.eu,
	linux-kernel@...r.kernel.org, ralf@...ux-mips.org, tj@...nel.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] of: specify initrd location using 64-bit

On 09/13/2012 12:08 AM, Rob Herring wrote:
>> Geert is right here. If it is a physical address, it should be
>> phys_addr_t.
>
> While generally true, for the DT specific code I think it should be a
> fixed u64. The size of the address is defined by the FDT, not the
> kernel. It is very likely we could have a FDT that specifies addresses
> in 64-bit values, but then we boot a kernel is compiled for !LPAE.
> phys_addr_t is currently sized based on LPAE setting.

If your kernel is 32bit without PAE and your DTB address is >32ibt than
you can't handle it. If you don't notice this in your dt code than you
remap the wrong memory ioremap().

>
> Rob
>

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/