linux-kernel - Re: [PATCH 3/3 v2] perf tool: give user better message if precise is not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120914113617.GA13299@gmail.com>
Date:	Fri, 14 Sep 2012 13:36:17 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	David Ahern <dsahern@...il.com>
Cc:	acme@...stprotocols.net, linux-kernel@...r.kernel.org,
	peterz@...radead.org, Robert Richter <robert.richter@....com>
Subject: Re: [PATCH 3/3 v2] perf tool: give user better message if precise is
 not supported

* David Ahern <dsahern@...il.com> wrote:

> On 9/13/12 11:43 PM, Ingo Molnar wrote:
> >>v2: softened message to 'may not be' supported per Robert's suggestion
> >
> > Well, either it's supported on this machine or it's not - 
> > why does the text have to be so unsure about it?
> 
> Because EOPNOTSUPP is returned for more than just precise 
> mode. We cannot say with certainty that the precise attribute 
> caused that errno.

Well, then that is useful information we *lost*, and that 
situation needs to be improved on the ABI side: an expanded 
error code present in the event structure, copied back to 
user-space on errors, or so.

(Alternatively, a special event channel just to pass back 
expanded error conditions.)

Computers are supposed to make life easier for humans, by 
answering such "what did go wrong?" questions. Our losing of 
precise error conditions is a usability bug really - and in the 
perf project we are in a unique position to be able to improve 
both the kernel side code and make immediate use of it on the 
tooling side as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/