linux-kernel - Re: section mismatch for acpi_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5057D123.7040109@cn.fujitsu.com>
Date:	Tue, 18 Sep 2012 09:40:51 +0800
From:	Wen Congyang <wency@...fujitsu.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	x86@...nel.org, linux-kernel@...r.kernel.org, mingo@...hat.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: section mismatch for acpi_unmap_lsapic()

At 09/17/2012 07:07 PM, Ingo Molnar Wrote:
> 
> * Jerry Snitselaar <dev@...tselaar.org> wrote:
> 
>> Commit 13ad20c1 "x86 cpu_hotplug: unmap cpu2node when the cpu is
>> hotremoved" in linux-next added code to acpi_unmap_lsapic() that
>> causes section mismatch warnings:
>>
>> WARNING: vmlinux.o(.text+0x694f2): Section mismatch in reference from the function acpi_unmap_lsapic()
>> 	  to the function .cpuinit.text:numa_clear_node()
>> WARNING: vmlinux.o(.text+0x694eb): Section mismatch in reference from the function acpi_unmap_lsapic() 
>> 	  to the variable .cpuinit.data:__apicid_to_node
>>
>>
>> Does acpi_unmap_lsapic() need a wrapper like the one that was made for
>> acpi_map_lsapic() or can it just be annotated __ref ? I guess my
>> question is would be there be a reason that the wrapper was created
>> for acpi_map_lsapic() instead of just annotating __ref besides
>> allowing the code for _apic_map_lsapic() to be dropped when
>> HOTPLUG_CPU wasn't configured?
> 
> That commit comes from -mm AFAICS. Involved parties Cc:-ed.

Sorry for introducing this warning. numa_clear_node() is in cpuinit
section, and it will be called in acpi_unmap_lsapic(), so I agree
to add __ref to this function. Should I need to post another patch
to fix it or just update the patch?

Thanks
Wen Congyang

> 
> Thanks,
> 
> 	Ingo
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/