linux-kernel - RE: [PATCH v2 1/4] drivers/mmc/host/dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <018101cd9586$4ac78b40$e056a1c0$%jun@samsung.com>
Date:	Tue, 18 Sep 2012 19:13:47 +0900
From:	Seungwon Jeon <tgih.jun@...sung.com>
To:	'Peter Senna Tschudin' <peter.senna@...il.com>, cjb@...top.org
Cc:	will.newton@...tec.com, jh80.chung@...sung.com,
	kyungmin.park@...sung.com, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: RE: [PATCH v2 1/4] drivers/mmc/host/dw_mmc.c: fix error return code

On Monday, September 17, 2012, Peter Senna Tschudin <peter.senna@...il.com> wrote:
> From: Peter Senna Tschudin <peter.senna@...il.com>
> 
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>

Looks good.
Acked-by: Seungwon Jeon <tgih.jun@...sung.com>

> --
> 1.7.11.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/