[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120919022550.GA6145@S2100-06.ap.freescale.net>
Date: Wed, 19 Sep 2012 10:25:53 +0800
From: Shawn Guo <shawn.guo@...aro.org>
To: Peter Senna Tschudin <peter.senna@...il.com>
CC: <cjb@...top.org>, <marex@...x.de>,
<broonie@...nsource.wolfsonmicro.com>,
<vinod.koul@...ux.intel.com>, <linux-mmc@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 4/4] drivers/mmc/host/mxs-mmc.c: fix error return code
On Mon, Sep 17, 2012 at 10:15:28AM +0200, Peter Senna Tschudin wrote:
> From: Peter Senna Tschudin <peter.senna@...il.com>
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
Acked-by: Shawn Guo <shawn.guo@...aro.org>
> ---
> drivers/mmc/host/mxs-mmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 80d1e6d..afd8fdd 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -674,6 +674,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
> if (!ssp->dmach) {
> dev_err(mmc_dev(host->mmc),
> "%s: failed to request dma\n", __func__);
> + ret = -ENODEV;
> goto out_clk_put;
> }
>
> --
> 1.7.11.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists