linux-kernel - Re: [PATCH] compat: fs: Generic compat_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201209181813.06124.arnd@arndb.de>
Date:	Tue, 18 Sep 2012 18:13:05 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	"David S. Miller" <davem@...emloft.net>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] compat: fs: Generic compat_sys_sendfile implementation

On Tuesday 18 September 2012, Catalin Marinas wrote:
> @@ -229,7 +229,7 @@ COMPAT_SYS_SPU(sched_setaffinity)
>  COMPAT_SYS_SPU(sched_getaffinity)
>  SYSCALL(ni_syscall)
>  SYSCALL(ni_syscall)
> -SYS32ONLY(sendfile64)
> +SYS32ONLY(sendfile64_wrapper)
>  COMPAT_SYS_SPU(io_setup)
>  SYSCALL_SPU(io_destroy)
>  COMPAT_SYS_SPU(io_getevents)

I believe this will break native ppc32 builds because there is
no sys_sendfile64_wrapper function. You probably have to use

SYSX(sys_ni_syscall, compat_sys_sendfile64_wrapper, sys_sendfile64)

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/