linux-kernel - Re: [PATCH] compat: fs: Generic compat_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120918.160659.160077660315513625.davem@davemloft.net>
Date:	Tue, 18 Sep 2012 16:06:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	catalin.marinas@....com
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	arnd@...db.de, benh@...nel.crashing.org, paulus@...ba.org,
	viro@...iv.linux.org.uk, akpm@...ux-foundation.org
Subject: Re: [PATCH] compat: fs: Generic compat_sys_sendfile implementation

From: Catalin Marinas <catalin.marinas@....com>
Date: Tue, 18 Sep 2012 18:02:06 +0100

> This function is used by sparc, powerpc and arm64 for compat support.
> The patch adds a generic implementation which calls do_sendfile()
> directly and avoids set_fs().
> 
> The sparc architecture has wrappers for the sign extensions while
> powerpc relies on the compiler to do the this. The patch adds a wrapper
> for powerpc to handle the u32->int type conversion.
> 
> compat_sys_sendfile64() can be replaced by a sys_sendfile() call since
> compat_loff_t has the same size as off_t on a 64-bit system. On powerpc,
> similar wrapper needs to be added for the u32->int conversion.
> 
> The reason for a single patch covering both powerpc and sparc is to keep
> it bisectable (and simple), otherwise kernel building may fail with
> mismatched function declarations.
> 
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/