linux-kernel - Re: [PATCH] compat: fs: Generic compat_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHkRjk581OE1ugsYKB-M8tZP5sYEsxLYkFPsfneLpnLKm3q9-A@mail.gmail.com>
Date:	Wed, 19 Sep 2012 11:57:42 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	"David S. Miller" <davem@...emloft.net>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] compat: fs: Generic compat_sys_sendfile implementation

On 18 September 2012 19:13, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 18 September 2012, Catalin Marinas wrote:
>> @@ -229,7 +229,7 @@ COMPAT_SYS_SPU(sched_setaffinity)
>>  COMPAT_SYS_SPU(sched_getaffinity)
>>  SYSCALL(ni_syscall)
>>  SYSCALL(ni_syscall)
>> -SYS32ONLY(sendfile64)
>> +SYS32ONLY(sendfile64_wrapper)
>>  COMPAT_SYS_SPU(io_setup)
>>  SYSCALL_SPU(io_destroy)
>>  COMPAT_SYS_SPU(io_getevents)
>
> I believe this will break native ppc32 builds because there is
> no sys_sendfile64_wrapper function. You probably have to use
>
> SYSX(sys_ni_syscall, compat_sys_sendfile64_wrapper, sys_sendfile64)

OK, I only built ppc64. I made this change and I'll re-post the patch.

What I've noticed on ppc64 is that __NR_sendfile is routed to
sys_sendfile64(). I'm changing this to sys_sendfile() as I don't see
why we need to carry the two almost identical functions around:

-SYSX_SPU(sys_sendfile64,compat_sys_sendfile,sys_sendfile)
+SYSX_SPU(sys_sendfile,compat_sys_sendfile_wrapper,sys_sendfile)

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/