linux-kernel - Re: [PATCH] x86: Dump family, model, stepping of the BSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120919105227.GC4577@aftab.osrc.amd.com>
Date:	Wed, 19 Sep 2012 12:52:27 +0200
From:	Borislav Petkov <bp@...64.org>
To:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Cc:	Andreas Herrmann <andreas.herrmann3@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: Dump family, model, stepping of the BSP

On Fri, Sep 14, 2012 at 06:37:46PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@....com>
> 
> When acting on a user bug report, we find ourselves constantly asking
> for /proc/cpuinfo in order to know the exact family, model, stepping of
> the CPU in question. Instead of having to ask this, add this to dmesg
> so that it is visible and no ambiguities can ensue from looking at the
> official name string of the CPU coming from CPUID and trying to map it
> to f/m/s.
> 
> Output then looks like this:
> 
> [    0.146041] smpboot: CPU0: AMD FX(tm)-8100 Eight-Core Processor (fam: 15 model: 01 stepping: 02)

Guys, any comments on this one? I think dumping the f/m/s is very
helpful.

Thanks.

> Signed-off-by: Borislav Petkov <borislav.petkov@....com>
> ---
>  arch/x86/kernel/cpu/common.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 2ea24da6f7fb..90f7f8f9212f 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1022,14 +1022,16 @@ void __cpuinit print_cpu_info(struct cpuinfo_x86 *c)
>  		printk(KERN_CONT "%s ", vendor);
>  
>  	if (c->x86_model_id[0])
> -		printk(KERN_CONT "%s", c->x86_model_id);
> +		printk(KERN_CONT "%s", strim(c->x86_model_id));
>  	else
>  		printk(KERN_CONT "%d86", c->x86);
>  
> +	printk(KERN_CONT " (fam: %02x model: %02x", c->x86, c->x86_model);
> +
>  	if (c->x86_mask || c->cpuid_level >= 0)
> -		printk(KERN_CONT " stepping %02x\n", c->x86_mask);
> +		printk(KERN_CONT " stepping: %02x)\n", c->x86_mask);
>  	else
> -		printk(KERN_CONT "\n");
> +		printk(KERN_CONT ")\n");
>  
>  	print_cpu_msr(c);
>  }
> -- 
> 1.7.11.rc1
> 
> 

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/