linux-kernel - Re: [RFCv2] remoteproc: Add STE modem driver for remoteproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120918194819.08538bed@pyramind.ukuu.org.uk>
Date:	Tue, 18 Sep 2012 19:48:19 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	sjur.brandeland@...ricsson.com
Cc:	Ohad Ben-Cohen <ohad@...ery.com>,
	Sjur Brændeland <sjurbren@...il.com>,
	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [RFCv2] remoteproc: Add STE modem driver for remoteproc

O> +	/* make sure the offsets array isn't truncated */
> +	if (table->num * sizeof(table->offset[0]) +
> +	    sizeof(struct resource_table) > entry->size) {
> +		sproc_err(sproc, "resource table incomplete\n");
> +		return NULL;

None of these checks appear to be robust against maths overflow. So the
question I'd ask is how far do you trust your inputs ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/