linux-kernel - Re: [RFCv2] remoteproc: Add STE modem driver for remoteproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Sep 2012 21:09:31 +0200
From:	Sjur Brændeland <sjurbren@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Ohad Ben-Cohen <ohad@...ery.com>, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [RFCv2] remoteproc: Add STE modem driver for remoteproc

On Tue, Sep 18, 2012 at 8:48 PM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> > +    /* make sure the offsets array isn't truncated */
>> +     if (table->num * sizeof(table->offset[0]) +
>> +         sizeof(struct resource_table) > entry->size) {
>> +             sproc_err(sproc, "resource table incomplete\n");
>> +             return NULL;
>
> None of these checks appear to be robust against maths overflow. So the
> question I'd ask is how far do you trust your inputs ?

The input is coming from user space via firmware loading framework,
so I guess it shouldn't be trusted at all. I'll try to improve these
sanity checks
in my next respin.

Thanks,
Sjur
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/