lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Sep 2012 11:35:44 +0530 From: Shubhrajyoti <shubhrajyoti@...com> To: Ryan Mallon <rmallon@...il.com> CC: rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org, julia.lawall@...6.fr Subject: Re: [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format On Tuesday 18 September 2012 07:14 AM, Ryan Mallon wrote: > On 17/09/12 23:58, Shubhrajyoti D wrote: >> Convert the struct i2c_msg initialization to C99 format. This makes >> maintaining and editing the code simpler. Also helps once other fields >> like transferred are added in future. >> >> Signed-off-by: Shubhrajyoti D <shubhrajyoti@...com> >> --- >> drivers/rtc/rtc-ds1672.c | 26 ++++++++++++++++++++++---- >> 1 files changed, 22 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c >> index 7fa67d0..b44b2a1 100644 >> --- a/drivers/rtc/rtc-ds1672.c >> +++ b/drivers/rtc/rtc-ds1672.c >> @@ -37,8 +37,18 @@ static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm) >> unsigned char buf[4]; >> >> struct i2c_msg msgs[] = { >> - {client->addr, 0, 1, &addr}, /* setup read ptr */ >> - {client->addr, I2C_M_RD, 4, buf}, /* read date */ >> + { >> + .addr = client->addr, >> + .flags = 0, >> + .len = 1, >> + .buf = &addr >> + }, /* setup read ptr */ > It would be nice to tabify the fields, and put the comments on their own > lines while you are here. With the C99 format you can also omit fields > which are initialised to zero. Like this: For local structures also? > > { > /* Setup read pointer */ > .addr = client->addr, > .len = 1, > .buf = &addr, > }, > > ~Ryan > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists