linux-kernel - Re: Davicom DM9000C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201209200908.00519.arnd@arndb.de>
Date:	Thu, 20 Sep 2012 09:08:00 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Jonathan Corbet <corbet@....net>
Cc:	Allen Huang (黃偉格) 
	<allen_huang@...icom.com.tw>, linux-kernel@...r.kernel.org,
	"'Michael Chen'" <michael_chen@...l.davicom.com.tw>,
	"'Charles'" <charles_tsai@...icom.com.tw>,
	"'Joseph Chang'" <joseph_chang@...l.davicom.com.tw>
Subject: Re: Davicom DM9000C driver

On Wednesday 19 September 2012, Jonathan Corbet wrote:
> On Wed, 19 Sep 2012 13:58:08 +0800
> Allen Huang (黃偉格)  <allen_huang@...icom.com.tw> wrote:
> 
> > I'm Allen Huang from Davicom. We are hereby opensourcing the linux
> > driver for our DM9000C. 
> 
> That is great, but please read the development process documentation on
> how best to submit something like this.  We would much rather see a patch
> (inline, not as an attachment) to facilitate the review.

More importantly, the patch should be against the version that is
already present in the kernel as drivers/net/ethernet/davicom/dm9000.c,
which appears to be mostly the same as the version that is submitted
here.

So while all the comments on the driver are valuable, they also apply
to the code we already have since 2005.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/