linux-kernel - Re: [PATCH v4] power_supply: add new lp8788 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120920221638.GF18223@lizard>
Date:	Thu, 20 Sep 2012 15:16:38 -0700
From:	Anton Vorontsov <anton.vorontsov@...aro.org>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] power_supply: add new lp8788 charger driver

On Wed, Sep 05, 2012 at 10:43:21AM +0000, Kim, Milo wrote:
>  TI LP8788 PMU supports regulators, battery charger, RTC,
>  ADC, backlight driver and current sinks.
> 
>  This patch supports the charger operations including
>  the charger interrupt handling.
[...]
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
> ---

Had to fix a bunch of checkpatch complaints:

CHECK: space prohibited before semicolon
#478: FILE: drivers/power/lp8788-charger.c:396:
+       for (i = 0 ; i < pdata->num_chg_params ; i++) {

CHECK: space prohibited before semicolon
#541: FILE: drivers/power/lp8788-charger.c:459:
+       for (i = 0 ; i < pchg->num_irqs ; i++) {


But other than this, it looks really good, this is now applied.

Obviously, I couldn't compile-test it, but hopefully it will work
once MFD part is also in. :-) If not, you can just send a follow-up
fix.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/