[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAK=WgbarKvbwRzjb9E=PEj_qQ46UxxrFTRuU9qOiDYSV+XQFxQ@mail.gmail.com>
Date: Sat, 22 Sep 2012 16:40:44 +0300
From: Ohad Ben-Cohen <ohad@...ery.com>
To: Sjur Brændeland <sjurbren@...il.com>
Cc: linux-kernel@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>,
Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCHv4] remoteproc: Add STE modem driver for remoteproc
On Sat, Sep 22, 2012 at 4:33 PM, Sjur Brændeland <sjurbren@...il.com> wrote:
>>>> It might be safer though to invoke ->setup() in probe/remove, instead
>>>> of in start/stop (just like you essentially did before).
>>>>
>>>> This way we don't assume that stop is always called before remove (as
>>>> assumption that might be implicitly valid today, but may break in the
>>>> future).
>>>>
>>>> If you want, I can just change that before applying.
>>>
>>> Sounds good, please just go ahead and change this before applying.
>>> Thank you.
>>
>> I'm going to squash the below into the patch - please ack before I
>> apply and push - thanks!
>
> Looks good, thanks.
>
> Acked-by: Sjur Brændeland <sjur.brandeland@...ricsson.om>
Thanks, applied and pushed to remoteproc's for-next branch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists