| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1348498747.618.4.camel@maxim-laptop> Date: Mon, 24 Sep 2012 16:59:07 +0200 From: Maxim Levitsky <maximlevitsky@...il.com> To: Tejun Heo <tj@...nel.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Alex Dubov <oakad@...oo.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] memstick: add support for legacy memorysticks On Thu, 2012-09-20 at 10:53 -0700, Tejun Heo wrote: > On Thu, Sep 20, 2012 at 07:05:42AM +0300, Maxim Levitsky wrote: > > There can't be races in the driver, since it contains a single thread > > that does all the IO it got from block layer. > > The thread is awaken each time the request function of block device is > > called. > > This why I didn't do much locking in here. In addition I found out that > > this is quite common way to implement a block device driver. > > Please use workqueue instead of raw kthread. > > Thanks! Now that my exams done.... Can you spare me from using a workqueue? The point is that using current model I wake the worker thread as much as I want to, and I know that it will be woken once an will do all the work till request queue is empty. With workqueues, it doesn't work this way. I have to pass the request as a work item or something like that. Any pointers? Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists