linux-kernel - Re: [PATCH] perf probe: print an enum type variable in "enum variable-name" format when showing accessible variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5064179E.4090507@hitachi.com>
Date:	Thu, 27 Sep 2012 18:08:46 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Hyeoncheol Lee <hyc.lee@...il.com>
Cc:	acme@...stprotocols.net, LKML <linux-kernel@...r.kernel.org>,
	"yrl.pp-manager.tt@...achi.com" <yrl.pp-manager.tt@...achi.com>
Subject: Re: [PATCH] perf probe: print an enum type variable in "enum variable-name"
 format when showing accessible variables

(2012/09/27 11:36), Hyeoncheol Lee wrote:
> When showing accessible variables, an enum type variable was
>  printed in "variable-name" format. Change this format into
> "enum variable-name".

Right, and even if the enum has a type name, it shows
only "type-name variable-name", this should show
"enum type-name variable-name".

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

Thank you!

> 
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> Signed-off-by: Hyeoncheol Lee <hyc.lee@...il.com>
> ---
>  tools/perf/util/dwarf-aux.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c
> index ee51e9b..3e5f543 100644
> --- a/tools/perf/util/dwarf-aux.c
> +++ b/tools/perf/util/dwarf-aux.c
> @@ -804,6 +804,8 @@ int die_get_typename(Dwarf_Die *vr_die, char *buf, int len)
>  			tmp = "union ";
>  		else if (tag == DW_TAG_structure_type)
>  			tmp = "struct ";
> +		else if (tag == DW_TAG_enumeration_type)
> +			tmp = "enum ";
>  		/* Write a base name */
>  		ret = snprintf(buf, len, "%s%s", tmp, dwarf_diename(&type));
>  		return (ret >= len) ? -E2BIG : ret;
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/