linux-kernel - Re: [ 043/218] ARM: 7527/1: uaccess: explicitly check __user pointer when !CPU_USE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348875393.6858.15.camel@deadeye.wl.decadent.org.uk>
Date:	Sat, 29 Sep 2012 01:36:33 +0200
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Russell King <rmk+kernel@....linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>
Subject: Re: [ 043/218] ARM: 7527/1: uaccess: explicitly check __user
 pointer when !CPU_USE_DOMAINS

On Fri, 2012-09-28 at 13:14 -0700, Greg Kroah-Hartman wrote:
> 3.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Russell King <rmk+kernel@....linux.org.uk>
> 
> commit 8404663f81d212918ff85f493649a7991209fa04 upstream.
> 
> The {get,put}_user macros don't perform range checking on the provided
> __user address when !CPU_HAS_DOMAINS.
> 
> This patch reworks the out-of-line assembly accessors to check the user
> address against a specified limit, returning -EFAULT if is is out of
> range.
> 
> [will: changed get_user register allocation to match put_user]
> [rmk: fixed building on older ARM architectures]
[...]

It looks like this is needed for at least some older kernel versions,
but a backported version will be needed for 3.2 and earlier.

Ben.

-- 
Ben Hutchings
Usenet is essentially a HUGE group of people passing notes in class.
                      - Rachel Kadel, `A Quick Guide to Newsgroup Etiquette'

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)