linux-kernel - Re: [ 035/218] vfs: make O_PATH file descriptors usable for fstat()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFx1Yg6OKD=dM+B2M9pDwVH__EdzJrDMGvuU=RXvY7qrOw@mail.gmail.com>
Date:	Fri, 28 Sep 2012 16:44:28 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk,
	ольга крыжановская <olga.kryzhanovska@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [ 035/218] vfs: make O_PATH file descriptors usable for fstat()

On Fri, Sep 28, 2012 at 4:27 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
>
> The upstream version exchanges fget_light() for fget_raw_light().  Since
> 3.2 (and likewise 3.4) have fget() here, I cherry-picked e994def 'VFS:
> make vfs_fstat() use f[get|put]_light()' before this.  Was that a
> bad/good/neutral idea?

Pretty neutral, I don't think it matters. Doing like greg did and just
doing it with fget_raw() (without the cherry-pick) is fine too.

            Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/