[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120928140833.GB7483@localhost.localdomain>
Date: Fri, 28 Sep 2012 10:08:34 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To: Joerg Roedel <joerg.roedel@....com>
Cc: iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/16] iommu/amd: Keep track of HPET and IOAPIC device ids
On Fri, Sep 28, 2012 at 02:23:51PM +0200, Joerg Roedel wrote:
> The IVRS ACPI table provides information about the IOAPICs
> and the HPETs available in the system and which PCI device
> ID they use in transactions. Save that information for later
> usage in interrupt remapping.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> ---
> drivers/iommu/amd_iommu.c | 3 ++
> drivers/iommu/amd_iommu_init.c | 65 +++++++++++++++++++++++++++++++++++++--
> drivers/iommu/amd_iommu_types.h | 34 ++++++++++++++++++++
> 3 files changed, 100 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index b64502d..6f51483 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -72,6 +72,9 @@ static DEFINE_SPINLOCK(iommu_pd_list_lock);
> static LIST_HEAD(dev_data_list);
> static DEFINE_SPINLOCK(dev_data_list_lock);
>
> +LIST_HEAD(ioapic_map);
> +LIST_HEAD(hpet_map);
> +
> /*
> * Domain for untranslated devices - only allocated
> * if iommu=pt passed on kernel cmd line.
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 18a89b7..a9f3948 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -55,6 +55,7 @@
> #define IVHD_DEV_ALIAS_RANGE 0x43
> #define IVHD_DEV_EXT_SELECT 0x46
> #define IVHD_DEV_EXT_SELECT_RANGE 0x47
> +#define IVHD_DEV_SPECIAL 0x48
>
> #define IVHD_FLAG_HT_TUN_EN_MASK 0x01
> #define IVHD_FLAG_PASSPW_EN_MASK 0x02
> @@ -690,6 +691,31 @@ static void __init set_dev_entry_from_acpi(struct amd_iommu *iommu,
> set_iommu_for_device(iommu, devid);
> }
>
> +static int add_special_device(u8 type, u8 id, u16 devid)
> +{
> + struct devid_map *entry;
> + struct list_head *list;
> +
> + if (type != 1 && type != 2)
> + return -EINVAL;
Should this be perhaps an enum? or #define?
> +
> + entry = kzalloc(sizeof(*entry), GFP_KERNEL);
> + if (!entry)
> + return -ENOMEM;
> +
> + entry->id = id;
> + entry->devid = devid;
> +
> + if (type == 1)
> + list = &ioapic_map;
> + else
> + list = &hpet_map;
> +
> + list_add_tail(&entry->list, list);
> +
> + return 0;
> +}
> +
Reviwed-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists